Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enumerate error codes #1493

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

bstasyszyn
Copy link
Contributor

Enumerate the errors and assign error codes. Also, add error code and error component to failure events.

@cla-bot cla-bot bot added the cla-signed label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (f81471d) 85.32% compared to head (25ec489) 85.27%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   85.32%   85.27%   -0.05%     
==========================================
  Files         166      166              
  Lines       10520    10581      +61     
==========================================
+ Hits         8976     9023      +47     
- Misses       1127     1137      +10     
- Partials      417      421       +4     
Files Coverage Δ
pkg/event/spi/spi.go 100.00% <ø> (ø)
pkg/restapi/resterr/error.go 88.46% <100.00%> (+8.46%) ⬆️
pkg/restapi/v1/issuer/controller.go 86.58% <100.00%> (-0.03%) ⬇️
pkg/restapi/v1/verifier/controller.go 91.51% <100.00%> (+0.01%) ⬆️
...g/service/clientidscheme/clientidscheme_service.go 87.34% <100.00%> (ø)
pkg/service/oidc4ci/claims.go 100.00% <100.00%> (ø)
.../mongodb/oidc4ciclaimdatastore/claim_data_store.go 92.30% <100.00%> (ø)
...storage/mongodb/oidc4cinoncestore/oidc4vc_store.go 100.00% <100.00%> (ø)
...e/mongodb/oidc4cistatestore/oidc4vc_state_store.go 92.45% <100.00%> (ø)
...ge/redis/oidc4ciclaimdatastore/claim_data_store.go 82.14% <100.00%> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enumerate the errors and assign error codes. Also, add error code and error component to failure events.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@fqutishat fqutishat closed this Oct 24, 2023
@fqutishat fqutishat reopened this Oct 24, 2023
@fqutishat fqutishat merged commit e5dda9a into trustbloc:main Oct 24, 2023
@bstasyszyn bstasyszyn deleted the error-codes branch October 24, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants