feat: OID4VCI combining metadata file #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1438 +/- ##
==========================================
- Coverage 85.34% 85.31% -0.03%
==========================================
Files 164 164
Lines 10338 10319 -19
==========================================
- Hits 8823 8804 -19
Misses 1107 1107
Partials 408 408
☔ View full report in Codecov by Sentry. |
mishasizov-SK
commented
Sep 27, 2023
Comment on lines
-51
to
-74
| { | ||
| "endpoint": "/issuer/{profileID}/{profileVersion}/.well-known/openid-configuration", | ||
| "method": "GET", | ||
| "input_query_strings": [ | ||
| "*" | ||
| ], | ||
| "backend_extra_config": { | ||
| "plugin/http-client": { | ||
| "name": "http-client-no-redirect" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "endpoint": "/oidc/idp/{profileID}/{profileVersion}/.well-known/openid-configuration", | ||
| "method": "GET", | ||
| "input_query_strings": [ | ||
| "*" | ||
| ], | ||
| "backend_extra_config": { | ||
| "plugin/http-client": { | ||
| "name": "http-client-no-redirect" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
@sudeshrshetty FYI - as discussed, I removed old endpoints
sudeshrshetty
approved these changes
Sep 27, 2023
fqutishat
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.