Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate claims in initiate-issuance of pre-auth flow #1433

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

bstasyszyn
Copy link
Contributor

Claims are validated against a JSON schema (if provided) during the initiate-issuance step of the pre-auth flow. The request is immediately rejected if the claims fail to validate.

Claims are validated against a JSON schema (if provided) during the initiate-issuance step of the pre-auth flow. The request is immediately rejected if the claims fail to validate.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Sep 21, 2023
@bstasyszyn bstasyszyn marked this pull request as draft September 21, 2023 15:50
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (232ab83) 85.34% compared to head (a95de6d) 85.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         164      164           
  Lines       10323    10338   +15     
=======================================
+ Hits         8810     8823   +13     
- Misses       1106     1107    +1     
- Partials      407      408    +1     
Files Changed Coverage Δ
pkg/doc/validator/jsonschema/jsonschema.go 92.98% <ø> (ø)
...rvice/oidc4ci/oidc4ci_service_initiate_issuance.go 92.56% <81.81%> (-0.52%) ⬇️
cmd/vc-rest/startcmd/start.go 80.93% <100.00%> (+0.07%) ⬆️
pkg/restapi/v1/issuer/controller.go 92.12% <100.00%> (ø)
pkg/service/oidc4ci/oidc4ci_service.go 94.69% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bstasyszyn bstasyszyn marked this pull request as ready for review September 25, 2023 13:11
@skynet2 skynet2 merged commit ea964d1 into trustbloc:main Sep 25, 2023
@bstasyszyn bstasyszyn deleted the validate-claims-pre-auth branch September 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants