Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add webfinger for VCT #910

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Conversation

sandrask
Copy link
Contributor

Add connection between Orb and VCT server for /vct webfinger query

Closes #890

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Nov 30, 2021
@sandrask sandrask changed the title feat: Add webfinger for VCT wip: Add webfinger for VCT Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #910 (ad55594) into main (e252870) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #910      +/-   ##
==========================================
- Coverage   89.39%   89.38%   -0.01%     
==========================================
  Files         157      157              
  Lines       14340    14369      +29     
==========================================
+ Hits        12819    12844      +25     
- Misses        932      936       +4     
  Partials      589      589              
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 73.16% <100.00%> (+0.03%) ⬆️
pkg/discovery/endpoint/restapi/operations.go 93.20% <100.00%> (+0.54%) ⬆️
pkg/webfinger/client/client.go 88.11% <100.00%> (+0.61%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️
pkg/taskmgr/taskmgr.go 89.16% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e252870...ad55594. Read the comment docs.

@sandrask sandrask force-pushed the issue-890 branch 4 times, most recently from ce34aa2 to e47ee3c Compare November 30, 2021 21:27
Add connection between Orb and VCT server for /vct webfinger query

Closes trustbloc#890

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask changed the title wip: Add webfinger for VCT chore: Add webfinger for VCT Nov 30, 2021
@fqutishat fqutishat merged commit 15a02b4 into trustbloc:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add connection between Orb and VCT server for /vct webfinger query
3 participants