Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename orb client to anchor origin provider #897

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

sandrask
Copy link
Contributor

Since we now have two orb clients(anchor origin provider and resolution verifier) we should move anchor origin provider into separate package orbclient/aoprovider. Also, move nsprovider and verprovider folders from orbclient to orbclient/protocol.

Closes #896

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

Since we now have two orb clients(anchor origin provider and resolution verifier) we should move anchor origin provider into separate package orbclient/aoprovider. Also, move nsprovider and verprovider folders from orbclient to orbclient/protocol.

Closes trustbloc#896

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #897 (67a585d) into main (7243e6d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
- Coverage   89.47%   89.42%   -0.06%     
==========================================
  Files         156      156              
  Lines       14000    14000              
==========================================
- Hits        12527    12519       -8     
- Misses        905      912       +7     
- Partials      568      569       +1     
Impacted Files Coverage Δ
pkg/orbclient/aoprovider/anchororiginprovider.go 87.50% <ø> (ø)
...orbclient/protocol/nsprovider/namespaceprovider.go 100.00% <ø> (ø)
.../orbclient/protocol/verprovider/versionprovider.go 100.00% <ø> (ø)
pkg/discovery/endpoint/client/client.go 85.32% <100.00%> (ø)
...orbclient/resolutionverifier/resolutionverifier.go 90.00% <100.00%> (ø)
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.12% <0.00%> (-9.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7243e6d...67a585d. Read the comment docs.

@fqutishat fqutishat merged commit f3e1de3 into trustbloc:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename orb client to anchor origin provider
3 participants