Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure http dial and request timeout #895

Merged
merged 1 commit into from
Nov 29, 2021
Merged

feat: configure http dial and request timeout #895

merged 1 commit into from
Nov 29, 2021

Conversation

fqutishat
Copy link
Contributor

closes #886

Signed-off-by: Firas Qutishat firas.qutishat@securekey.com

@cla-bot cla-bot bot added the cla-signed label Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #895 (1314409) into main (b29209b) will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
+ Coverage   89.37%   89.42%   +0.04%     
==========================================
  Files         157      157              
  Lines       14226    14245      +19     
==========================================
+ Hits        12715    12738      +23     
+ Misses        929      924       -5     
- Partials      582      583       +1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/params.go 79.81% <63.63%> (-0.37%) ⬇️
cmd/orb-server/startcmd/start.go 73.08% <100.00%> (+0.34%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 100.00% <0.00%> (+9.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29209b...1314409. Read the comment docs.

closes #886

Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
@fqutishat fqutishat merged commit a91b04a into trustbloc:main Nov 29, 2021
@fqutishat fqutishat deleted the update branch November 29, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP client should have different timeout for dial
3 participants