chore: Refactor batch writer witness collection #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor batch writer witnesses collection for offer activity: send individual system witness URLs instead of one preconfigured 'system' witness URL that points to system witnesses collection. Required in order to send only a subset of witnesses (as per policy) in the future. Closes trustbloc#861 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 89.29% 89.30%
=======================================
Files 148 148
Lines 13168 13177 +9
=======================================
+ Hits 11759 11768 +9
Misses 865 865
Partials 544 544
Continue to review full report at Codecov.
|
bstasyszyn
approved these changes
Nov 5, 2021
fqutishat
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor batch writer witnesses collection for offer activity: send individual system witness URLs instead of one preconfigured 'system' witness URL that points to system witnesses collection. Required in order to send only a subset of witnesses (as per policy) in the future.
Closes #861
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com