feat: Only run one DB expiry check per cluster at a time #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
from
0fa8aa6
to
3075755
Compare
Codecov Report
@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 89.38% 89.44% +0.05%
==========================================
Files 144 144
Lines 12638 12700 +62
==========================================
+ Hits 11297 11359 +62
+ Misses 828 825 -3
- Partials 513 516 +3
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
from
3075755
to
8ea382b
Compare
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
from
8ea382b
to
6834ac1
Compare
|
@bstasyszyn I've updated this PR per our conversation earlier. Take a look and let me know. If it looks okay, I can improve the code coverage. Some of the cases to improve code coverage are going to be time-consuming to cover, so if I need to make any major changes I should do that first before writing unit tests for them. |
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
from
6834ac1
to
95e4f48
Compare
bstasyszyn
approved these changes
Oct 20, 2021
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
2 times, most recently
from
f921c8c
to
de3d23e
Compare
fqutishat
approved these changes
Oct 20, 2021
sandrask
approved these changes
Oct 20, 2021
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
4 times, most recently
from
0d257a8
to
4257bae
Compare
Added a mechanism to the expiry service to allow it to coordinate with other Orb servers within a cluster so that they can ensure only one DB expiry check at a time. Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
DRK3
force-pushed
the
OnlyRunOneExpiryServicePerClusterAtATime
branch
from
4257bae
to
50b3fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a mechanism to the expiry service to allow it to coordinate with other Orb servers within a cluster so that they can ensure only one DB expiry check at a time.
Signed-off-by: Derek Trider Derek.Trider@securekey.com
closes #810