Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return the canonical DID in a WebFinger query #782

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

bstasyszyn
Copy link
Contributor

When an interim DID is used as a resource ID for a WebFinger query, the response returns the canonical DID if it has been anchored.

closes #780

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

When an interim DID is used as a resource ID for a WebFinger query, the response returns the canonical DID if it has been anchored.

closes trustbloc#780

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Sep 20, 2021
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #782 (70a0398) into main (8820a16) will increase coverage by 0.11%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   89.83%   89.94%   +0.11%     
==========================================
  Files         139      140       +1     
  Lines       11795    11818      +23     
==========================================
+ Hits        10596    10630      +34     
+ Misses        738      732       -6     
+ Partials      461      456       -5     
Impacted Files Coverage Δ
pkg/resolver/resource/registry/registry.go 100.00% <ø> (ø)
pkg/discovery/endpoint/restapi/operations.go 92.55% <92.85%> (+3.62%) ⬆️
pkg/discovery/endpoint/restapi/anchorinfo.go 100.00% <100.00%> (ø)
...r/resource/registry/didanchorinfo/didanchorinfo.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8820a16...70a0398. Read the comment docs.

@fqutishat fqutishat merged commit 2f247e6 into trustbloc:main Sep 21, 2021
@bstasyszyn bstasyszyn deleted the 780 branch September 21, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return canonical DID in WebFinger when using an interim DID
3 participants