Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump golangci-lint to v1.52 #1539

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

bstasyszyn
Copy link
Contributor

Updated golangci-lint to v1.52 and also changed the linter config such that all linters are initially enabled and selected linters are disabled. This ensures that linters are not overlooked.

Code changes were required to resolve problems detected by the newly enabled linters.

@cla-bot cla-bot bot added the cla-signed label Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 98.30% and project coverage change: -0.01 ⚠️

Comparison is base (8eb67d6) 88.04% compared to head (928e11b) 88.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   88.04%   88.04%   -0.01%     
==========================================
  Files         226      226              
  Lines       21075    21072       -3     
==========================================
- Hits        18555    18552       -3     
  Misses       1616     1616              
  Partials      904      904              
Impacted Files Coverage Δ
...cli/ipnshostmetauploadcmd/ipnshostmetauploadcmd.go 86.90% <ø> (ø)
pkg/activitypub/resthandler/openapi.go 0.00% <ø> (ø)
pkg/activitypub/store/spi/spi.go 70.73% <ø> (ø)
pkg/activitypub/vocab/util.go 83.33% <ø> (ø)
pkg/nodeinfo/openapi.go 0.00% <ø> (ø)
pkg/observability/loglevels/loglevels.go 93.02% <ø> (ø)
pkg/observability/metrics/noop/provider.go 98.87% <ø> (ø)
cmd/orb-cli/common/common.go 73.25% <80.00%> (ø)
...ctivitypub/service/activityhandler/inboxhandler.go 83.57% <90.00%> (ø)
cmd/orb-cli/common/activitypubclient.go 85.71% <100.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Updated golangci-lint to v1.52 and also changed the linter config such that all linters are initially enabled and selected linters are disabled. This ensures that linters are not overlooked.

Code changes were required to resolve problems detected by the newly enabled linters.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit 8893ba5 into trustbloc:main Mar 31, 2023
@bstasyszyn bstasyszyn deleted the golangci branch March 31, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants