Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Go version to 1.19 #1509

Merged
merged 1 commit into from
Oct 11, 2022
Merged

chore: Update Go version to 1.19 #1509

merged 1 commit into from
Oct 11, 2022

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Oct 6, 2022

This also required an update to the latest golangci-lint v1.50.0. So this PR fixes the problems flagged by the latest linter.

closes #1485

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2022
@bstasyszyn bstasyszyn marked this pull request as draft October 9, 2022 17:56
This also required an updated to the latest golangci-lint v1.50.0. So this PR fixes the problems flagged by the latest linter.

closes trustbloc#1485

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 88.14% // Head: 88.07% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (578d266) compared to base (efd0bb9).
Patch coverage: 79.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   88.14%   88.07%   -0.07%     
==========================================
  Files         218      218              
  Lines       20782    20793      +11     
==========================================
- Hits        18318    18314       -4     
- Misses       1575     1587      +12     
- Partials      889      892       +3     
Impacted Files Coverage Δ
cmd/orb-driver/startcmd/start.go 47.82% <0.00%> (-0.42%) ⬇️
internal/pkg/cmdutil/cmdutil.go 84.21% <ø> (ø)
internal/pkg/ldcontext/ldcontext.go 61.53% <ø> (ø)
internal/pkg/log/fields.go 98.73% <ø> (ø)
internal/pkg/log/logger.go 96.47% <ø> (ø)
pkg/activitypub/resthandler/openapi.go 0.00% <0.00%> (ø)
pkg/activitypub/resthandler/resthandler.go 89.47% <ø> (ø)
...ctivitypub/service/activityhandler/inboxhandler.go 83.38% <ø> (ø)
...vitypub/service/anchorsynctask/activitysynctask.go 88.23% <ø> (ø)
pkg/activitypub/service/service.go 94.36% <ø> (ø)
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn marked this pull request as ready for review October 10, 2022 15:27
@fqutishat fqutishat merged commit a42ec85 into trustbloc:main Oct 11, 2022
@bstasyszyn bstasyszyn deleted the 1485 branch October 11, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go to 1.19
4 participants