Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add did:web handler to /sidetree/v1/identifiers path #1473

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Sep 1, 2022

Create new did resolution handler that will handle did:orb and did:web resolution cases.

Closes #1459

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Sep 1, 2022
@sandrask sandrask changed the title chore: Add handler for did:orb in wip: Add handler for did:orb in Sep 1, 2022
@sandrask sandrask force-pushed the issue-1459 branch 3 times, most recently from 4d44412 to 9ec67d7 Compare September 1, 2022 21:22
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1473 (08cfc35) into main (d1d1cc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files         209      210    +1     
  Lines       19759    19760    +1     
=======================================
+ Hits        17355    17356    +1     
  Misses       1545     1545           
  Partials      859      859           
Impacted Files Coverage Δ
pkg/discovery/endpoint/restapi/operations.go 89.10% <ø> (-0.38%) ⬇️
cmd/orb-server/startcmd/start.go 68.98% <100.00%> (+0.03%) ⬆️
pkg/document/didresolver/resolvehandler.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sandrask sandrask changed the title wip: Add handler for did:orb in wip: Add handler for did:orb to /1.0/identifiers path Sep 2, 2022
@sandrask sandrask changed the title wip: Add handler for did:orb to /1.0/identifiers path Add did:web handler to /sidetree/v1/identifiers path Sep 6, 2022
We are currently exposing two DID resolution endpoints:

protected endpoint /sidetree/v1/identifiers for did:orb

unprotected endpoint /1.0/identifiers for did:web and did:orb

Closes trustbloc#1459

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask merged commit c2a5373 into trustbloc:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate impact of having one resolution endpoint for did:orb and did:web etc.
3 participants