Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add backoff to operation queue retries #1389

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

bstasyszyn
Copy link
Contributor

When an operation in the queue fails to process then the retry adds a delay so that the message broker doesn't retry the operation immediately.

closes #1137

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

When an operation in the queue fails to process then the retry adds a delay so that the message broker doesn't retry the operation immediately.

closes trustbloc#1137

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1389 (74769a8) into main (ec15f9d) will increase coverage by 0.06%.
The diff coverage is 88.31%.

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   87.97%   88.04%   +0.06%     
==========================================
  Files         205      205              
  Lines       19048    19106      +58     
==========================================
+ Hits        16758    16821      +63     
+ Misses       1470     1467       -3     
+ Partials      820      818       -2     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 67.31% <ø> (ø)
pkg/pubsub/mempubsub/mempubsub.go 93.13% <0.00%> (-1.87%) ⬇️
pkg/pubsub/amqp/amqppubsub.go 89.57% <88.00%> (+1.65%) ⬆️
pkg/context/opqueue/opqueue.go 82.28% <88.57%> (-0.19%) ⬇️
cmd/orb-server/startcmd/params.go 82.60% <100.00%> (+0.52%) ⬆️
pkg/vct/proofmonitoring/monitoring.go 84.07% <0.00%> (-2.66%) ⬇️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 97.77% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec15f9d...74769a8. Read the comment docs.

@bstasyszyn bstasyszyn merged commit 224d8bc into trustbloc:main Jun 28, 2022
@bstasyszyn bstasyszyn deleted the 1137 branch June 28, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation queue retries should have a backoff
2 participants