Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create_dids_to_file BDD test scenario #1385

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

bstasyszyn
Copy link
Contributor

Move the setup portion to scenario, create_and_verify_dids_from_file, since this is the only scenario that runs in the CI.

closes #1383

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Move the setup portion to scenario, create_and_verify_dids_from_file, since this is the only scenario that runs in the CI.

closes trustbloc#1383

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1385 (91d61cc) into main (41ab9a7) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
+ Coverage   87.94%   87.97%   +0.02%     
==========================================
  Files         205      205              
  Lines       19029    19029              
==========================================
+ Hits        16735    16740       +5     
+ Misses       1471     1468       -3     
+ Partials      823      821       -2     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/start.go 67.57% <0.00%> (-0.33%) ⬇️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)
...pub/service/inbox/httpsubscriber/httpsubscriber.go 97.77% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ab9a7...91d61cc. Read the comment docs.

@bstasyszyn bstasyszyn merged commit 93674f8 into trustbloc:main Jun 27, 2022
@bstasyszyn bstasyszyn deleted the 1383 branch June 27, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create-dids-to-file BDD scenario does not work in AMS
2 participants