feat: Public key store/cache for Observer #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 87.87% 87.87% -0.01%
==========================================
Files 173 174 +1
Lines 17397 17471 +74
==========================================
+ Hits 15288 15352 +64
- Misses 1345 1351 +6
- Partials 764 768 +4
Continue to review full report at Codecov.
|
bstasyszyn
force-pushed
the
1261
branch
2 times, most recently
from
23b246b
to
e0dbe6f
Compare
Implemented a public key storage and cache for the Observer. When verifying a witness proof, the Observer will load the public key of the signer from the cache/database. If it doesn't exist in the DB then the public key is retrieved using the public key fetcher. Also enhanced the BDD test so that, when creating DIDs on multiple targets, the target will be greylisted if it is down and the create will be performed on another target. closes trustbloc#1261 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
sandrask
approved these changes
Apr 26, 2022
fqutishat
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a public key storage and cache for the Observer. When verifying a witness proof, the Observer will load the public key of the signer from the cache/database. If it doesn't exist in the DB then the public key is retrieved using the public key fetcher.
Also enhanced the BDD test so that, when creating DIDs on multiple targets, the target will be greylisted if it is down and the create will be performed on another target.
closes #1261
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com