This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
fix: merge didcomm v2/v1 handling #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 87.55% 87.70% +0.15%
==========================================
Files 28 29 +1
Lines 4244 4296 +52
==========================================
+ Hits 3716 3768 +52
Misses 308 308
Partials 220 220
Continue to review full report at Codecov.
|
Moopli
force-pushed
the
pr-634
branch
3 times, most recently
from
c11c467 to
2b91546
Compare
Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
fqutishat
approved these changes
Feb 28, 2022
| @@ -16,6 +16,6 @@ echo "Running adapter integration tests with tag=$TAGS" | |||
| go test -count=1 -v -cover . -p 1 -timeout=40m $TAGS | |||
|
|
|||
| echo "Running adapter didcomm v2 integration tests" | |||
| AGENT_KEY_TYPE=ecdsap256ieee1363 AGENT_KEY_AGREEMENT_TYPE=p256kw USE_DIDCOMM_V2=true AGENT_MEDIA_TYPE_PROFILES=didcomm/v2 go test -count=1 -v -cover . -p 1 -timeout=40m -run waci_didcommv2 | |||
| go test -count=1 -v -cover . -p 1 -timeout=40m -run waci_didcommv2 | |||
There was a problem hiding this comment.
@Moopli Do we need to run this separately now that we have merged both into one ?
There was a problem hiding this comment.
We'd need to modify the tests to clear connection data from the containers, it's just simpler to start them fresh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.