Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

feat: WACI Issuance support #565

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

sudeshrshetty
Copy link
Member

Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #565 (f1bc75c) into main (6ab6035) will decrease coverage by 0.04%.
The diff coverage is 86.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   87.29%   87.25%   -0.05%     
==========================================
  Files          29       29              
  Lines        3874     4071     +197     
==========================================
+ Hits         3382     3552     +170     
- Misses        286      303      +17     
- Partials      206      216      +10     
Impacted Files Coverage Δ
pkg/profile/issuer/profile.go 89.47% <ø> (ø)
pkg/restapi/issuer/operation/operations.go 89.86% <86.53%> (-0.76%) ⬇️
pkg/restapi/rp/operation/operations.go 85.51% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab6035...f1bc75c. Read the comment docs.

- support for WACI issuance
- wallet redirect URL & QR Code support
- integration tests based on aries universal wallet
- Closes trustbloc#556
- Closes trustbloc#554
- Closes trustbloc#553
- Closes trustbloc#555

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Copy link

@birtony birtony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudeshrshetty can you add a screenshot of the UI, please?

@sudeshrshetty
Copy link
Member Author

sudeshrshetty commented Jan 7, 2022

@sudeshrshetty can you add a screenshot of the UI, please?

This PR is about adapter backend integration only, no changes has been done for UI except showing QRCode & Redirect.
The UI changes you see are just JS refactoring to support both CHAPI & WACI in same UI and copy of redirect/QRcode part from existing WACI share page.

image

@sudeshrshetty sudeshrshetty merged commit 05a9d64 into trustbloc:main Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants