First pass at updating for tf12 #9
Conversation
|
|
||
| policy = "${data.aws_iam_policy_document.logs_policy_doc.json}" | ||
| policy = data.aws_iam_policy_document.logs_policy_doc.json | ||
| } | ||
|
|
||
| # This code verifies that the count of policy ARNs matches the actual |
There was a problem hiding this comment.
Do we still need this workaround? I'm not sure I understand the particular limitation that Terraform has/had here and if that got fixt in TF12?
There was a problem hiding this comment.
I've been thinking about potentially doing this in 2 phases
- to make our modules syntactically work with 0.12
- refactor the modules to more closely align with the 0.12 feature set.
That being said I'm open to other opinions.
There was a problem hiding this comment.
I think this was the Terraform issue that was forcing this workaround: hashicorp/terraform#14677. This is supposedly fixed in 0.12 from the sound of it. I tend to agree with @dynamike that a two-stage process works pretty well. I also wanted to try and get this sorted out ASAP under the assumption we can make it prettier later.
There was a problem hiding this comment.
in which case, I'll approve.
I went through and made the necessary changes to get this working in TF12; I was able to successfully create a lambda job in the sandbox account using this code.