Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docusaurus to version 2.2.0 and use npm #301

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

kleinschmidtj
Copy link
Contributor

@kleinschmidtj kleinschmidtj commented Oct 31, 2022

This PR updates docusaurus and removes yarn from the project to use npm.

After testing out using npm start and npm run build, I wasn't able to load the site locally. Each page crashed with this message: Hook is called outside the <DocsPreferredVersionContextProvider>. Updating docusaurus fixed the issue.

List of changes:

  • Updates docusaurus to version 2.2.0
  • Adds yarn.lock to ignore files list
  • Updates docs to use npm commands
  • Updates CI/CD to use npm

@kleinschmidtj kleinschmidtj changed the title Update docusaurus and use npm Update docusaurus to version 2.2.0 and use npm Oct 31, 2022
@rogeruiz rogeruiz self-requested a review October 31, 2022 16:09
Copy link
Contributor

@rogeruiz rogeruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌈

great work on this @kleinschmidtj and thank you @rpdelaney for helping surface these issues up in Slack.

Comment on lines +22 to +24
# yarn
yarn.lock

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May yarn not ever show up in the repository. ❤️ 🤞🏽

Comment on lines +18 to +20
"@docusaurus/core": "^2.2.0",
"@docusaurus/plugin-client-redirects": "^2.2.0",
"@docusaurus/preset-classic": "^2.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to see us move away from the pre-release of 2.0.0!

@rogeruiz rogeruiz merged commit 696296d into main Oct 31, 2022
@rogeruiz rogeruiz deleted the jfk-use-npm branch October 31, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants