Support full Yubico OATH AID #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full AID is used by eg. Yubico Authenticator on Android, which previously would not recognise the Trussed OATH implementation.
|
OK, I realised I mixed up my keys and I do have a hacker one! Verified to work with both |
|
🦗 |
|
Bump |
|
Bump, it would be great to have this integrated finally, seeing as there is no alternative authenticator app for mobile |
|
Yo, Nick and friends. You still there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients, like Yubico Authenticator on Android, use the full AID for the OATH app, while the Trussed impl is one byte shorter and so isn't currently recognised.
See for example the Yubico Authenticator source.
This change just bumps the AID out per your original comment. I have to apologise, I'm not in a position to test it myself (still waiting on a solo2 hacker key).