core: Make heapless support optional and support multiple versions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
heapless
branch
from
88ac6c2 to
e3ebbfc
Compare
sosthene-nitrokey
approved these changes
Aug 16, 2024
|
@sosthene-nitrokey What do you think about adding support for |
|
That looks like a good idea. But optional like for heapless. |
daringer
approved these changes
Sep 10, 2024
|
Added support for |
robin-nitrokey
force-pushed
the
heapless
branch
from
1a82b7e to
5bb2dfd
Compare
The DynFile::read_to_end, DynFilesystem::read and DynFilesystem::read_chunk methods use a heapless::Vec to store a flexible amount of data. This patch introduces a Vec trait that abstracts over different versions of heapless so that we can optionally support multiple heapless versions at the same time. Fixes: #77
Similar to the existing support for multiple heapless versions, this patch also adds support for heapless-bytes 0.3 and 0.4.
robin-nitrokey
force-pushed
the
heapless
branch
from
5bb2dfd to
a1f8d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DynFile::read_to_end,DynFilesystem::readandDynFilesystem::read_chunkmethods use aheapless::Vecto store a flexible amount of data. This patch introduces aVectrait that abstracts over different versions of heapless so that we can optionally support multiple heapless versions at the same time.Fixes: #77