Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Internal improvement: Create shrinkwrap for truffle-cli #2609

Closed
wants to merge 2 commits into from

Conversation

CruzMolina
Copy link
Contributor

Pins all packages/truffle deps & pushes shrinkwrap generated from all cli dependencies.

Inspired by #2555 .

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 73.41% when pulling e727180 on shrinkwrapCLI into be5289a on develop.

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need this to automatically update?

@CruzMolina
Copy link
Contributor Author

There's two cases that come to mind:

  • If we add a dep to the cli, we'll need to update the shrinkwrap.
  • If we expect or want devs to use the cli as a devDep, we'll need to update the shrinkwrap & publish the cli, after bumping/publishing the org pkgs.

It seems that we recommend devs/users install the cli globally and don't expect them to consume it as a devDep. Still, not sure whether we want to move forward with this.

@CruzMolina
Copy link
Contributor Author

Closing since there doesn't seem to be interest in doing this.

@CruzMolina CruzMolina closed this Jan 31, 2020
@gnidan gnidan deleted the shrinkwrapCLI branch November 23, 2020 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants