This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix tests for web3-provider-ws@1.0.0-beta.33 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In web3-provider-ws v1.0.0-beta.33 they changed the callback behavior from cb(err, response) to cb(response), but it seems some instances make the callback without passing the error while other instances make the callback with an error and response. This change deals with both possible inputs to the callback function. An alternative might be to pin web3-provider-ws to 1.0.0-beta.30.
|
Also addresses the build failures in #95 |
This was referenced Apr 16, 2024
This was referenced Oct 13, 2024
This was referenced Oct 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In web3-provider-ws v1.0.0-beta.33 they changed the callback behavior
from cb(err, response) to cb(response), but it seems some instances
make the callback without passing the error while other instances make
the callback with an error and response. This change deals with both
possible inputs to the callback function.
An alternative might be to pin web3-provider-ws to 1.0.0-beta.30.