This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat: add ability to use blockHash with eth_getLogs #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Any feedback on this PR or ideas on when it can be merged? In the meantime, we published it at |
davidmurdoch
approved these changes
Sep 29, 2020
davidmurdoch
changed the title
davidmurdoch
added a commit
that referenced
this pull request
Sep 29, 2020
This reverts commit fb16896.
|
I didn't notice you changed the package name since I last looked at it and accidentally merged it with that extra commit. Reverted. |
|
Sorry about that extra commit, I didn't mean to push that here. Will reopen without that commit. Meant to push that to my local fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the ability to use
blockHashwitheth_getLogs. This closes #136See EIP 234