This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix: forking value and code deletion/destruction #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where data deleted from a forked chain that previously existed on the originating chain can't actually be deleted.
This fixes the issue for storage and for contract code. It doesn't do anything for accounts because I don't think accounts can't be deleted? If I'm wrong we can add in the
keyIsDeletedguards around forked account lookup too.Deletion is not block-number aware and only looks at the head, this is a known issue with most of the forking methods that I hope to finally fix soon.
Fixes #446 and #474.