This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: upgrade ethereumjs packages #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
force-pushed
the
upgrade-ejs
branch
from
07cb093 to
bfa39ff
Compare
MicaiahReid
changed the title
MicaiahReid
force-pushed
the
upgrade-ejs
branch
from
d2887ef to
b314f7c
Compare
MicaiahReid
force-pushed
the
upgrade-ejs
branch
from
06dd5f9 to
b6b0dd7
Compare
MicaiahReid
changed the base branch from
tech-debt-dudes
to
combine-ejs-ganache-address
MicaiahReid
commented
Nov 9, 2022
| @@ -48,18 +48,19 @@ | |||
| "truffle" | |||
| ], | |||
| "dependencies": { | |||
| "@ethereumjs/common": "3.0.0", | |||
| "@ethereumjs/common": "3.0.1", | |||
| "@ethereumjs/util": "8.0.2", | |||
There was a problem hiding this comment.
I have added @ethereumjs/util to this package because I was getting compilation errors. The @ethereumjs/common dependency used stuff from the @ethereumjs/util library, but I believe it was using an older version, which was causing type errors. It was hard to pin down the exact cause, so that reason could be a little off. But this does fix it.
tenthirtyone
approved these changes
Nov 9, 2022
Base automatically changed from
combine-ejs-ganache-address
to
tech-debt-dudes
November 9, 2022 21:41
MicaiahReid
force-pushed
the
upgrade-ejs
branch
from
dbd23b3 to
22c2562
Compare
MicaiahReid
force-pushed
the
upgrade-ejs
branch
from
ecc0bc3 to
6d90786
Compare
MicaiahReid
added a commit
that referenced
this pull request
Nov 14, 2022
MicaiahReid
added a commit
that referenced
this pull request
Nov 14, 2022
MicaiahReid
added a commit
that referenced
this pull request
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.