feat: add eth_createAccessList RPC method (#3321)

src/chains/ethereum/ethereum/src/helpers/simulations.ts

@@ -489,11 +489,7 @@ export const runCall = async ({
     overrides
   });
 
-  // we want to warm the access list provided by the user for a run call but
-  // _not_ for creating an access list. warming the addresses ahead of time will
-  // make it so that the contents of the user-provided access list are _always_
-  // in the generated access list, but we want the generated access list to be
-  // the "best". so we do this here rather than in the common setup functions
+  // we want to warm the access list provided by the user
   if (common.isActivatedEIP(2930) && transaction.accessList) {
     warmAccessList(stateManager, transaction.accessList);
   }
@@ -546,12 +542,14 @@ export const createAccessList = async ({
   // no real reason why this is our max, feel free to change
   const MAX_ITERATIONS = 1000;
   let previousAccessList = transaction.accessList || [];
+  let callResult: EVMResult;
   let iterations = 0;
   do {
     // checkpoint so we can get back to this vm state after every time we
     // run this loop
     await stateManager.checkpoint();
-    const callResult = await _runCall({
+    warmAccessList(stateManager, previousAccessList);
+    callResult = await _runCall({
       blockchain,
       runCallOpts,
       vm,
@@ -566,18 +564,42 @@ export const createAccessList = async ({
     // generated by the VM, or the VM generated the same access list twice
     // in a row, so this is our "best" access list.
     if (AccessLists.areAccessListsSame(previousAccessList, accessList)) {
-      const { dataFeeEIP2930 } = AccessLists.getAccessListData(accessList);
-      const baseFeeBigInt = intrinsicGas + dataFeeEIP2930;
-      const gasUsedBigInt =
-        Quantity.toBigInt(callResult.gasUsed.toArrayLike(Buffer)) +
-        baseFeeBigInt;
-      const gasUsed = Quantity.from(gasUsedBigInt);
+      const gasUsed = _getAccessListGasUsed(
+        accessList,
+        intrinsicGas,
+        callResult
+      );
       return { accessList, gasUsed };
     } else {
       // we are going to run this loop again so revert our changes
       await stateManager.revert();
+      stateManager.clearWarmedAccounts();
       previousAccessList = accessList;
     }
     iterations++;
   } while (iterations < MAX_ITERATIONS);
+  // we've tried too many times, but so return our latest attempt
+  const gasUsed = _getAccessListGasUsed(
+    previousAccessList,
+    intrinsicGas,
+    callResult
+  );
+  return { accessList: previousAccessList, gasUsed };
+};
+
+/**
+ * @returns {Quantity} The gas used by the transaction with the EIPP2930 data
+ * fee.
+ */
+const _getAccessListGasUsed = (
+  accessList: AccessList,
+  intrinsicGas: bigint,
+  callResult: EVMResult
+) => {
+  const { dataFeeEIP2930 } = AccessLists.getAccessListData(accessList);
+  const baseFeeBigInt = intrinsicGas + dataFeeEIP2930;
+  const gasUsedBigInt =
+    Quantity.toBigInt(callResult.gasUsed.toArrayLike(Buffer)) + baseFeeBigInt;
+  const gasUsed = Quantity.from(gasUsedBigInt);
+  return gasUsed;
 };