This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Only use the last selected flavor if it is supported #5212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to be writing tests for these changes, but the codebase is not set up to support this. Once this release goes out I'll be looking to improve on the test automation for the project. |
jeffsmale90
changed the title
davidmurdoch
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading the home screen, the previously selected flavor is always selected by default - for instance, if the user last started a "Filecoin" workspace, then the "Filecoin" flavor would be selected.
Before to this change, if the previously selected flavor was no longer supported (ie "Corda"), it would still be selected. Starting the workspace would cause an error "Workspace not found" to be thrown.
This change causes the default ("Ethereum") workspace to be selected if the previously selected flavor is no longer supported.