This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: show helpful error message when port is occupied #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
changed the title
cds-amal
reviewed
Dec 12, 2022
static/node/chain/chain.ethereum.js
Outdated
| const { message, stack} = err; | ||
| let {code} = err; | ||
| // todo: we may be able to remove this check once https://github.com/trufflesuite/ganache/issues/4020 is resolved | ||
| if (code === undefined && message && message.indexOf("listen EADDRINUSE") === 0) { |
There was a problem hiding this comment.
Should it be > 0? If it's supposed to be 0, then perhaps use string.startsWith?
There was a problem hiding this comment.
It should be string.startsWith because the error message explicitly is listen EADDRINUSE: <reason> - I'll change to that.
Thanks!
davidmurdoch
suggested changes
Dec 12, 2022
static/node/chain/chain.filecoin.js
Outdated
| @@ -108,7 +108,16 @@ async function startServer(options) { | |||
| try { | |||
| await server.listen(options.port, options.hostname); | |||
| } catch (err) { | |||
| process.send({ type: "start-error", data: {code: err.code, stack: err.stack, message: err.message} }); | |||
| const { message, stack} = err; | |||
There was a problem hiding this comment.
Suggested change
| const { message, stack} = err; | |
| const { message, stack } = err; |
static/node/chain/chain.filecoin.js
Outdated
| @@ -108,7 +108,16 @@ async function startServer(options) { | |||
| try { | |||
| await server.listen(options.port, options.hostname); | |||
| } catch (err) { | |||
| process.send({ type: "start-error", data: {code: err.code, stack: err.stack, message: err.message} }); | |||
| const { message, stack} = err; | |||
| let {code} = err; | |||
There was a problem hiding this comment.
Suggested change
| let {code} = err; | |
| let { code } = err; |
| @@ -19,6 +19,7 @@ process.on("unhandledRejection", err => { | |||
|
|
|||
| process.on("uncaughtException", err => { | |||
| //console.log('uncaught exception:', err.stack || err) | |||
| // hilariously EADDRINUSE errors will get raised here | |||
There was a problem hiding this comment.
Suggested change
| // hilariously EADDRINUSE errors will get raised here | |
| // hilariously, EADDRINUSE errors will get raised here |
static/node/chain/chain.ethereum.js
Outdated
| @@ -108,9 +108,16 @@ async function startServer(options) { | |||
| try { | |||
| await server.listen(options.port, options.hostname); | |||
| } catch (err) { | |||
| const { message, stack} = err; | |||
| let {code} = err; | |||
There was a problem hiding this comment.
Suggested change
| let {code} = err; | |
| let { code } = err; |
static/node/chain/chain.ethereum.js
Outdated
| @@ -108,9 +108,16 @@ async function startServer(options) { | |||
| try { | |||
| await server.listen(options.port, options.hostname); | |||
| } catch (err) { | |||
| const { message, stack} = err; | |||
There was a problem hiding this comment.
Suggested change
| const { message, stack} = err; | |
| const { message, stack } = err; |
|
@davidmurdoch @cds-amal I've made those changes, and merged, just because I wanted to incorporate into the github actions branch. If you have any more concerns, I'm happy to fix them up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.