Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Incorrect timestamp of blocks mined #268

Closed
cameronrll opened this issue Jan 13, 2018 · 1 comment
Closed

Incorrect timestamp of blocks mined #268

cameronrll opened this issue Jan 13, 2018 · 1 comment

Comments

@cameronrll
Copy link
Contributor

Depending on which page you look at the "mined on" info on, it changes. On the "Blocks" tab it displays the correct time, however if you click on the block in the list it will always show :01:00

image

image

image

image

Expected Behavior

Correct timestamp to be shown on both screens

Current Behavior

One correct, one wrong.

Possible Solution

Looks like it is just a bug in the ui, that is only correctly displaying the hour, but forcing the rest to be :01:00

issue is likely here.

MiniBlockCard.js (how mined on is formatted)

            <div className="RowItem">
              <div className="MinedOn">
                <div className="Label">MINED ON</div>
                <div className="Value">
                  <Moment unix format="YYYY-MM-DD HH:mm:ss">
                    {block.timestamp}
                  </Moment>
                </div>
              </div>
            </div>

BlockCard.js (where issue is)

       <div className="Label">MINED ON</div>
              <div className="Value">
                <Moment unix format="YYYY-MM-DD HH:MM:SS">
                  {block.timestamp}
                </Moment>
              </div>
       </div>

notice the difference

  • YYYY-MM-DD HH:mm:ss (correct formatting)
  • YYYY-MM-DD HH:MM:SS (incorrect formatting)

Steps to Reproduce (for bugs)

  1. Cause blocks to be created near the hour change (e.g create 1st block at 2:59:00 and 2nd at 3:04:00)
  2. Look at the blocks on the block tab, and note the correct time
  3. Click on 1st block and notice how the time is now 2:01:00
  4. Click on 2nd block and notice how the time is now 3:01:00

Your Environment

  • Version used: v1.0.2
  • Operating System and version: Ubuntu 16.0
benjamincburns added a commit that referenced this issue Mar 8, 2018
#268 Fixed mined on time formatting issue on BlockCard
@mikeseese
Copy link
Contributor

Fixed in #269

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants