Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Fix/react15 contract data not updating #57

Merged
merged 4 commits into from
Feb 13, 2019

Conversation

honestbonsai
Copy link
Contributor

@honestbonsai honestbonsai commented Feb 13, 2019

Fixes #4 #13

Note that this targets React 15 on master. Another one will be coming for React 16 on next.

You can test this by using drizzle-box and just changing accounts on Metamask. You should see the TutorialToken balance update correctly. Only Account 0 should have any balance.

Thanks to @carlosescom @Aare- for their original PRs

@adrianmcli
Copy link
Contributor

lgtm

@honestbonsai honestbonsai merged commit e76572c into master Feb 13, 2019
@honestbonsai honestbonsai deleted the fix/react15-contractData-notUpdating branch February 13, 2019 20:10
@samajammin
Copy link
Contributor

samajammin commented Feb 14, 2019

Sweet! @honestbonsai just for my understanding - is there a roadmap to upgrade master to React 16? Or should I rely on next branch?

I opened an issue in this drizzle box that's related to the React versions across these projects: truffle-box/drizzle-box#77

@honestbonsai
Copy link
Contributor Author

honestbonsai commented Feb 14, 2019

@sbrichards That's pretty much the next thing on my list to do. Going to try to port the changes from next into master.

master has received a number of fixes that next doesn't have, so need to work through those potential conflicts.

If you need React 16 support immediately, just use next branch. But I'm aiming to get this done soon. Thanks for your interest and support in drizzle-react-components!

@honestbonsai
Copy link
Contributor Author

honestbonsai commented Feb 14, 2019

@sbrichards FYI refer to #63 if you want to provide some feedback on the new API for React 16.3 context components for v1.x.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants