Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Debug version Println to logrus debug - Issue #992 #993

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

yilmi
Copy link
Contributor

@yilmi yilmi commented Jan 2, 2023

Hi,

I created the Issue #992 for this pull request, the problem is that when debug is enabled, we print the trufflehog version in STDOUT instead of STDERR:

❯ trufflehog filesystem --directory hack 2>/dev/null
❯ trufflehog filesystem --directory hack --debug 2>/dev/null
trufflehog 3.21.0

The change is minor and shouldn't required additional testing or have much impact.

Thanks!

@yilmi yilmi requested a review from a team as a code owner January 2, 2023 15:53
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this!

@mcastorina mcastorina merged commit 330a6f7 into trufflesecurity:main Jan 3, 2023
@yilmi yilmi deleted the debug-flag-stdout branch January 3, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants