Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browserstack regex #808

Merged
merged 4 commits into from
Sep 25, 2022
Merged

Browserstack regex #808

merged 4 commits into from
Sep 25, 2022

Conversation

rahuljaisinghani
Copy link
Contributor

  • The old regex do not consider all the types of keys. The new regex covers all the old and new format of browserstack keys
  • wrt documentation and sample scripts, added more keywords for improving detection

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ahrav
ahrav approved these changes Sep 25, 2022
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks a lot for updating this. We really appreciate it.

@ahrav ahrav merged commit 3645a6e into trufflesecurity:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahuljaisinghani @CLAassistant @ahrav