[chore] - Use config struct instead of pointer for engine scans. #709
Conversation
main.go
Outdated
| @@ -200,7 +200,7 @@ func run(state overseer.State) { | |||
| c.Filter = filter | |||
| } | |||
|
|
|||
| if err = e.ScanGit(ctx, sources.NewConfig(g)); err != nil { | |||
| if err = e.ScanGit(ctx, *sources.NewConfig(g)); err != nil { | |||
There was a problem hiding this comment.
Suggestion: make sources.NewConfig return the struct instead of a pointer so we don't have to deref here.
There was a problem hiding this comment.
yea i had thought about going that route. I guess I left it this way since it was the standard way that everyone is used to seeing this functional options implemented. One of those things where when you take a quick glance you just kinda go, "oh its doing that" and almost automatically think it should return a pointer. Similar to how we are used to seeing err != nil and when we see err == nil it usually requires a double take, or like e being used instead of err.
That being said I don't have a strong personal pref on this.
There was a problem hiding this comment.
Cool, thanks for sharing your reasoning! I'm not familiar with that pattern so it didn't occur to me.
Use a config struct instead of pointer when scanning engine sources.
Remove the nil check from each scan.