Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve debug logging for GHE enum #615

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Conversation

dustin-decker
Copy link
Contributor

No description provided.

Copy link
Collaborator

@trufflesteeeve trufflesteeeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some optional comments for potentially using the sources default logger instead of the global logger.

pkg/sources/github/github.go Outdated Show resolved Hide resolved
pkg/sources/github/github.go Outdated Show resolved Hide resolved
@dustin-decker dustin-decker merged commit 8051b03 into main Jun 8, 2022
@dustin-decker dustin-decker deleted the improve-ghe-logging branch June 8, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants