Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cloudconvert detector #543

Merged

Conversation

roxanne-tampus
Copy link
Contributor

No description provided.

Copy link
Contributor

@galevalerie galevalerie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly validate and update the regex pattern. i tried creating API keys and some are not matching with the provided regex. create API keys using different scopes.

@roxanne-tampus
Copy link
Contributor Author

Updated the regex with ranges. Please check if this could suffice your created keys. Thanks!

@dustin-decker
Copy link
Contributor

You can try running JWT tokens (long tokens with ey prefix) through a JWT parser like https://jwt.io/ to see if it contains variables that can be different lengths.

Copy link
Contributor

@galevalerie galevalerie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in the regex seems okay to me. I've also tested it with my created tokens and with the jwt decoder.

@dustin-decker dustin-decker merged commit c9f1f61 into trufflesecurity:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants