Update GitHub action metadata to use ghcr.io image #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR implements what we discussed on #493. You can see my test results here.
Runs 1, 2 and 8 were done using the old mode (
Dockerfile
). They took around 3 minutes of runner time just to build the images.Runs 5, 6 and 7 took around 3 seconds to pull the prebuilt image from ghcr.io 🤯
I'm using the
latest
tag, as requested, and it seems to be working fine with regards to action metadata requirements. However, as you can see by the commit history on themain
branch (and also comparing results from workflow runs 7 and 8), I couldn't getthe new workflow to find any secrets on the repo.
I'm raising the PR as a draft while I investigate if this is an issue with the metadata change. If there is something I'm overlooking, please leave a comment here.