Added zulipchat scanner #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/detectors/zulipchat/zulipchat.go
Outdated
| //Make sure that your group is surrounded in boundry characters such as below to reduce false positives | ||
| keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"zulipchat"}) + `\b([0-9a-zA-Z]{32})\b`) | ||
| idPat = regexp.MustCompile(detectors.PrefixRegex([]string{"zulipchat"}) + `\b([a-z0-9]{4,25}@[a-zA-Z0-9]{2,12}.[a-zA-Z0-9]{2,6})\b`) | ||
| domainPat = regexp.MustCompile(detectors.PrefixRegex([]string{"zulipchat domain"}) + `\b([0-9a-z]{6,20})\b`) |
There was a problem hiding this comment.
zulipchat domain is unlikely to be found within 40 characters of the pattern in the wild. Just zulipchat for the keyword.
dustin-decker
approved these changes
Apr 29, 2022
bill-rich
pushed a commit
that referenced
this pull request
May 2, 2022
* added new protos * added new detectors * added zulipchat scanner * modified regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.