-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added typetalk scanner #410
Added typetalk scanner #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice LGTM 👍
pkg/detectors/typetalk/typetalk.go
Outdated
} | ||
|
||
if verify { | ||
req, err := http.NewRequestWithContext(ctx, "POST", "https://typetalk.com/oauth2/access_token?client_id="+resIdMatch+"&client_secret="+resMatch+"&grant_type=client_credentials", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Prefer fmt.Sprintf when there are multiple variables within the string.
fmt.Sprintf("https://typetalk.com/oauth2/access_token?client_id=%s&client_secret=%s&grant_type=client_credentials", resIdMatch, resMatch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed the enhancement, thanks @ahrav!
* added new protos * added new detectors * added typetalk scanner * enhanced endpoint
No description provided.