-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parsehub scanner #403
Added parsehub scanner #403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, otherwise lgtm
pkg/detectors/parsehub/parsehub.go
Outdated
} | ||
|
||
if verify { | ||
req, err := http.NewRequestWithContext(ctx, "GET", "https://www.parsehub.com/api/v2/projects?api_key="+resMatch+"&offset=0&limit=20&include_options=1", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: prefer fmt.Sprintf("https://www.parsehub.com/api/v2/projects?api_key=%s&limit=1", resMatch)
and additionally you can also likely remove the additional query params to the request to make it simpler. I would potentially also just change the limit to 1 to also potentially reduce the request latency and size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ahrav! Pushed the enhancement.
* added new protos * added new detectors * added parsehub scanner * enhanced enpoint
No description provided.