Add Data member to ResultsMetadata struct. #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Result is emitted, it should include the `chunk.Data []byte` so that we can utilize the blob of data which caused the result. This makes it so something catching the results does not have to maintain a collection of chunks to correlate the two together.
|
|
dustin-decker
approved these changes
May 24, 2023
strazzere
added a commit
to strazzere/trufflehog
that referenced
this pull request
May 26, 2023
Add Data member to ResultsMetadata struct. (trufflesecurity#1358)
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Result is emitted, it should include
the
chunk.Data []byteso that we can utilizethe blob of data which caused the result.
This makes it so something catching the results
does not have to maintain a collection of chunks
to correlate the two together.
This fixes/implements the proposed feature described
in #1357