Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log to track git log size #1325

Merged
merged 2 commits into from
May 2, 2023
Merged

Add log to track git log size #1325

merged 2 commits into from
May 2, 2023

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented May 2, 2023

No description provided.

@ahrav ahrav marked this pull request as ready for review May 2, 2023 22:59
@ahrav ahrav requested a review from a team as a code owner May 2, 2023 22:59
@bill-rich
Copy link
Collaborator

The concept looks good, but the totalLogSize should also be added to here since that is what handled especially large commits. You could also add it here, but it only deals with the last commit.

@ahrav
Copy link
Collaborator Author

ahrav commented May 2, 2023

The concept looks good, but the totalLogSize should also be added to here since that is what handled especially large commits. You could also add it here, but it only deals with the last commit.

Ohhh, nice. I completely missed those.

bill-rich
bill-rich approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ahrav ahrav merged commit 714c480 into main May 2, 2023
@ahrav ahrav deleted the log-git-log-commit-size branch May 2, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @bill-rich