Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scripts to benchmark and plot performance across tags #1293

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

dustin-decker
Copy link
Contributor

Produces data and a plot for user time spent scanning a given repo for the last N tags, averaged over 5 runs.

@dustin-decker dustin-decker requested a review from a team as a code owner April 26, 2023 21:24
Copy link
Collaborator

@mcastorina mcastorina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It would be cool to have this in CI at some point to catch perf regressions before they get merged.

hack/bench/versions.sh Outdated Show resolved Hide resolved
user_time=$(echo $time_output | awk '{print $3}')

# Add the user time to the sum
user_time_sum=$(echo "$user_time_sum + $user_time" | bc)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Are you using bc because it supports larger numbers than $(( ))?

Copy link
Contributor Author

@dustin-decker dustin-decker Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bc because the LLM told me to...

@dustin-decker
Copy link
Contributor Author

Nice! It would be cool to have this in CI at some point to catch perf regressions before they get merged.

I think Zach is looking at doing that. Something like comparing the last two tags and exiting 1 if there is a >10% perf decrease.

@dustin-decker dustin-decker merged commit 4086895 into main Apr 26, 2023
@dustin-decker dustin-decker deleted the benchmark-and-plot-perf branch April 26, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants