Fix git commit date string formatting #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Git dates are formatted with two timezones due to the way
time.Time.String()
is implemented. This change outputs the date in a similar, almost-RFC3339 format, but with the timezone only appearing once.The way that Go's date formatting works makes me a bit uncomfortable, but it must work well enough given that all of the built-in date formats use it, so I followed the same pattern. The date used in the implementation is the one used by Go's
time.RFC3339
since the string being output is similar.Example
Resources
time.Time.String()
documentation