[chore] Remove logrus from trufflehog #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
force-pushed
the
chore-logs
branch
2 times, most recently
from
caab14e
to
2c51263
Compare
mcastorina
force-pushed
the
chore-logs
branch
from
2c51263
to
ef1603c
Compare
ahrav
reviewed
Feb 14, 2023
| @@ -24,7 +22,7 @@ func BuildRegex(pattern string, specialChar string, length int) string { | |||
|
|
|||
| func BuildRegexJWT(firstRange, secondRange, thirdRange string) string { | |||
| if RangeValidation(firstRange) || RangeValidation(secondRange) || RangeValidation(thirdRange) { | |||
| log.Error("Min value should not be greater than or equal to max") | |||
| panic("Min value should not be greater than or equal to max") | |||
There was a problem hiding this comment.
Yeah, this seemed like an appropriate use of panic to me since this is more of a convenience function for some detectors. Previously we just logged an error and built the invalid regex anyway, so I think it's fine?
ahrav
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.