Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-124670 / 24.04 / Reporting disks view improvements for large disk systems #9076

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

AlexKarpov98
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 commented Oct 19, 2023

Testing: See updated select component with "Select All" option.
Screenshot 2023-10-27 at 00 56 36

Screenshot 2023-10-27 at 00 57 17

@AlexKarpov98 AlexKarpov98 self-assigned this Oct 19, 2023
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner October 19, 2023 14:56
@AlexKarpov98 AlexKarpov98 requested review from dszidi and removed request for a team October 19, 2023 14:56
@bugclerk bugclerk changed the title NAS-124670: Reporting disks view improvements for large disk systems NAS-124670 / 24.04 / Reporting disks view improvements for large disk systems Oct 19, 2023
@bugclerk
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 requested a review from undsoft October 19, 2023 15:01
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #9076 (ff97620) into master (e001645) will increase coverage by 0.81%.
Report is 25 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9076      +/-   ##
==========================================
+ Coverage   62.07%   62.88%   +0.81%     
==========================================
  Files        1322     1325       +3     
  Lines       49447    49767     +320     
  Branches     5843     5874      +31     
==========================================
+ Hits        30692    31294     +602     
+ Misses      18755    18473     -282     
Files Coverage Δ
...-forms/components/ix-select/ix-select.component.ts 97.75% <100.00%> (+0.97%) ⬆️
...obal-controls/reports-global-controls.component.ts 0.00% <ø> (ø)

... and 122 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@undsoft undsoft removed their request for review October 20, 2023 06:49
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but 1) icon doesn't match the result of the select options 2) I don't think we need it by default

@AlexKarpov98
Copy link
Contributor Author

It works, but 1) icon doesn't match the result of the select options 2) I don't think we need it by default

I agree, PR is updated now 😺 (and images descriptions)

@AlexKarpov98 AlexKarpov98 requested a review from undsoft October 26, 2023 22:02
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants