-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-124670 / 24.04 / Reporting disks view improvements for large disk systems #9076
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9076 +/- ##
==========================================
+ Coverage 62.07% 62.88% +0.81%
==========================================
Files 1322 1325 +3
Lines 49447 49767 +320
Branches 5843 5874 +31
==========================================
+ Hits 30692 31294 +602
+ Misses 18755 18473 -282
... and 122 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but 1) icon doesn't match the result of the select options 2) I don't think we need it by default
src/app/modules/ix-forms/components/ix-select/ix-select.component.ts
Outdated
Show resolved
Hide resolved
I agree, PR is updated now 😺 (and images descriptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Testing: See updated select component with "Select All" option.