Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133825 / 25.10 / Update backups only once at the end #11459

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

bvasilenko
Copy link
Contributor

Testing:

For replication steps please see ticket

@bvasilenko bvasilenko requested a review from a team as a code owner February 2, 2025 17:06
@bvasilenko bvasilenko requested review from AlexKarpov98 and removed request for a team February 2, 2025 17:06
@bugclerk bugclerk changed the title NAS-133825: Update backups only once at the end NAS-133825 / 25.10 / Update backups only once at the end Feb 2, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Feb 2, 2025

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (1619474) to head (617dc07).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11459   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files        1676     1677    +1     
  Lines       60164    60244   +80     
  Branches     6372     6392   +20     
=======================================
+ Hits        50114    50183   +69     
- Misses      10050    10061   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting solution, not sure how to solve it in a different way 👌

@bvasilenko bvasilenko enabled auto-merge (squash) February 3, 2025 13:05
@bvasilenko bvasilenko merged commit 5a0a258 into master Feb 3, 2025
11 checks passed
@bvasilenko bvasilenko deleted the NAS-133825 branch February 3, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants