Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133572 / 25.04 / Allow users to log in to docker registries in the UI #11362

Merged
merged 2 commits into from
Jan 21, 2025

NAS-133572: PR update

cb52e11
Select commit
Loading
Failed to load commit list.
Merged

NAS-133572 / 25.04 / Allow users to log in to docker registries in the UI #11362

NAS-133572: PR update
cb52e11
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

82.93% (+0.01%) compared to fdda7b3

View this Pull Request on Codecov

82.93% (+0.01%) compared to fdda7b3

Details

Codecov Report

Attention: Patch coverage is 89.37500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (fdda7b3) to head (cb52e11).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...egistries-list/docker-registries-list.component.ts 86.84% 10 Missing ⚠️
...er-registry-form/docker-registry-form.component.ts 92.20% 6 Missing ⚠️
src/app/pages/apps/apps.routes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11362      +/-   ##
==========================================
+ Coverage   82.92%   82.93%   +0.01%     
==========================================
  Files        1666     1670       +4     
  Lines       59715    59875     +160     
  Branches     6276     6287      +11     
==========================================
+ Hits        49516    49659     +143     
- Misses      10199    10216      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.