Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131139 / 25.04 / Updates to Running toggle in services #10695

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Sep 17, 2024

Changes:

Running column in services has been reworked.

Testing:

Test column.

@undsoft undsoft requested a review from a team as a code owner September 17, 2024 11:55
@undsoft undsoft requested review from bvasilenko and removed request for a team September 17, 2024 11:55
@bugclerk bugclerk changed the title NAS-131139: Updates to Running toggle in services NAS-131139 / 25.04 / Updates to Running toggle in services Sep 17, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 88.73239% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (67d62bf) to head (8822f46).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ice-state-column/service-state-column.component.ts 88.40% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10695      +/-   ##
==========================================
+ Coverage   79.72%   79.78%   +0.06%     
==========================================
  Files        1564     1565       +1     
  Lines       51521    51529       +8     
  Branches     5856     5848       -8     
==========================================
+ Hits        41073    41111      +38     
+ Misses      10448    10418      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regressions found

@undsoft undsoft merged commit db283e7 into master Sep 19, 2024
9 checks passed
@undsoft undsoft deleted the NAS-131139 branch September 19, 2024 07:03
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants