Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow Custom Approval or Denial Words #66

Conversation

Bwvolleyball
Copy link
Contributor

Allows a user to specify comma-separated approval / denial words, hashtags, emojis, etc. Little things to make their culture rock!

It works with unicode emojis - this was tricky, see notes in the readme. Also had to account for the random spaces GitHub might add to the end of the comment.

It works with text emojis <-- the non-unicode emojis, like their custom :shipit: one worked right away!

it works with hash tags

Denials work as well! <-- took me some time to debug the ✅ emoji, but should work for the others!

@Bwvolleyball
Copy link
Contributor Author

Any feedback or requests for this change @trstringer ?

@trstringer
Copy link
Owner

Sorry for the delay! I will review this PR as soon as possible (hopefully within the next week).

@Bwvolleyball Bwvolleyball mentioned this pull request Jan 5, 2023
@trstringer trstringer merged commit 639442a into trstringer:main Feb 17, 2023
@trstringer
Copy link
Owner

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants